https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy |release-notes-needed --- Comment #70 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Thanks Aleisha for your quick follow-up, very appreciated. Take a look at the 2 last follow-ups I have attached, they fixed few more things and remove duplication of code. You should also make sure your commit messages fit the coding guidelines (https://wiki.koha-community.org/wiki/Commit_messages#Examples), maybe you should update your qa-test-tools repo, there are new checks to catch that. This new enhancement is well polished and the code is easy to read. Congrats! -- You are receiving this mail because: You are watching all bug changes.