https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42826 Gretchen Maxeiner <maxeinergl@gcc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from Gretchen Maxeiner <maxeinergl@gcc.edu> --- Thank you for the rebase! I have given this some testing and have feedback. These features were easy to use and generally worked smoothly. I hit on a couple of issues and then also have a few comments. New Report Owner field (Test plan 1) • On the Edit SQL screen in the Report Owner field, autocomplete offers ALL patrons, not just those with staff permissions, let alone those with reports permissions. This means reports can be assigned to people with no ability to access them. It would seem best to limit the selection to just staff. If it isn’t possible to restrict the autocomplete, a warning that the person selected isn’t appropriate would be helpful. • On the Edit SQL screen in the Report Owner field, it is possible to not select one of the options from autocomplete or to type too short a text for autocomplete to activate, and thus to fill out the field without matching to a person and save. This essentially blanks the field after save. It would be good to have a warning before saving if what’s been entered hasn’t matched to a person. • I could not get the autocomplete to work for a staff with edit_all_reports permission. It also failed if I gave all Reports permissions (reports). It only worked when I assigned superlibrarian permissions. • I wasn’t sure how to do step 11, but I did test creating guided reports at the various permission levels and the Report Owner field on the Edit SQL page’s visibility was correct as described for the other steps. • Otherwise, all works correctly as described. Orphan report adoption (Test plan 2) • This all worked correctly as described. Bulk ownership transfer (Test plan 3) • Here again I could not get autocomplete to work at the edit_all_reports permission level. This effectively blocks bulk transfer for these users. • Also, it is again possible to fill in the field without selecting an autocomplete suggestion, or filling in too little for autocomplete to activate, and then move on to the transfer. This brings up an ugly error screen. • Otherwise, this worked very smoothly. • I notice that the bulk transfer option is present (for users with edit_all_reports permission) not only on the Saved Reports list page but also in the options section on many other Reports pages (guide reports, edit SQL, reports results page, and perhaps more). I don’t think it is needed these places, but it may not be a concern. General • It is awkward to name the field “Report Owner” on the Edit SQL screen but “Author” in the reports list. Could these be sync’ed? “Report Owner” is the more accurate label if we are overwriting the original author for ownership changes. • It is also awkward that the “Report Owner” field on the Edit SQL screen shows the cardnumber but it is name and borrowernumber in the “Author” field in the reports list. I think these should be sync’ed also. • It might be nice to have a “me” option in here when editing “Report Owner” on the SQL edit page and on the Bulk Transfer page in the to or from fields. In a large number of instances, I expect the person making the changes will be the patron being entered. -- You are receiving this mail because: You are watching all bug changes.