https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 --- Comment #173 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #152)
(In reply to Jonathan Druart from comment #151)
Patches rebased.
I have provided a small enhancement on bug 27131 to move some code to a method. I don't think we could do more here, if you look at the code it read good and is pretty trivial (it's just a matter a few ->search calls).
I have done all what I could do get this ready, hopefully it will be approved and pushed soon :)
Sending back to the NQA queue.
My first impression here is: I knew that the query was ugly but replacing it by a huge number of DBIx calls will probably degrade the performance significantly. And if we make so many changes in a script, we should really go to a module.
Have you seen bug 27131? Thanks for the review, Marcel! -- You are receiving this mail because: You are watching all bug changes.