http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13914 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Eivin Giske Skaaren from comment #2)
I am still very new to Koha so please excuse (and explain) if I am thinking wrong here:
The query that gets fired when testing this bug looks like this:
[skip]
So one way of getting line numbers that are not unique for the same col is if priority is set to >0 for an item in the old_reserves table.
Question: Should priority ever be anything else than 0 for an item in the old_reserves table?
Yes, I think so. At least I have some on local installation. I suppose the priority is not updated when a reserve is canceled. So if it has a priority > 0, it will be copied as it to the old_reserves.
Perhaps this is better solved by getting the SQL correct for the use case, perhaps by adding a field to the result set that is unique?
I assumed that the query was correct. But as you can see, it is ugly and there is certainly a better way to do the same work.
This patch then does not solve the problem if the things that I have assumed are correct.
Did you have the patience to test/compare the results? I didn't :) But the customer validated the patch, so I supposed he tested it. If you are able to give me a simple example to recreate a issue on my side, I will have a look and try to provide a fix. -- You are receiving this mail because: You are watching all bug changes.