https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #41 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Cook from comment #40)
(In reply to Marcel de Rooy from comment #35)
Not sure (yet) but should the default not be zero? Just do not fork like we currently do?
The job needs to run in a forked process. The memory used by the job can be reclaimed when the child process ends - whereas the memory will never be reclaimed by the OS if the process doesn't fork. (The memory can be re-used if it's internally freed within Perl but can't be reclaimed by the OS.)
Probably you misread my comment ;) My formulations are compact. Note that this patch leaves the original fork in the process_job sub. To keep current behavior (parent process, 1 fork in process_job) the default should be zero. Not one. "Just do not fork" refers to the extra fork that we introduce here around calling process_job. And that actually introduces a double fork that we might want to get rid of too.. So the default could be 1 IF we remove the fork in the sub. -- You are receiving this mail because: You are watching all bug changes.