https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Did not finish this one completely now, but feel somehow that it needs more attention still (qa intuition). Hmm. Reserves still contains: expirationdate => $hold->patron_expiration_date, Are we not respecting that one? my %updated_columns = $self->_result->get_dirty_columns; return $self->SUPER::store unless %updated_columns; This may be obvious. But should we add $hold_reverted here? Or just trust that we have dirty columns coming from RevertWaitingStatus? + ( C4::Context->preference('DefaultHoldExpirationdate') + && ! exists $updated_columns{expirationdate} ) + || ( C4::Context->preference('DefaultHoldExpirationdate') + && exists $updated_columns{expirationdate} + && $hold_reverted ) Still breaking my head here. Could you please clarify in meantime a bit? Thx Status change for feedback. -- You are receiving this mail because: You are watching all bug changes.