http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7304 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #18 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- The size of this patch and the relative small changes to the code (compared to last version) may justify keeping it in Signed-off state. Several points of QA comment have received attention. No dependency is added. Good to see that you also remove the warning on redefine. Although I still believe that some code improvements could be made here as referred to in my previous comments, they should not block this patch from getting through. Passed QA -- You are receiving this mail because: You are watching all bug changes.