https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #7)
Before this patch, the action logged contained the itemnumber, not now. Would it make sense to keep it? We have the accountlines_id, so we could get the itemnumber from it. But it could be handy to have it directly. I am not sure this is relevant but I prefer to ask.
After serious consideration, I think we should *not* be logging the itemnumber directly . This was actually making the logs messier. It is predicated on the assumption that a single writeoff action only affects a single fee. Basically, a "write off all" action was indistinguishable to making many individual writeoffs in the way it was coded. Now the writeoff all action works in a more sensible manner, it makes no sense to have an itemnumber key. For these reasons I recommend do not add itemnumber directly. -- You are receiving this mail because: You are watching all bug changes.