https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38832 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from David Cook <dcook@prosentient.com.au> --- There's a couple of QA tool failures. I imagine the tidiness one could probably be ignored I guess, but that $page issue should be fixed. (Actually, I think neither of the $page variables are actually used anywhere...) Thanks for taking a look at the search scripts. They can clearly benefit from a review... -- FAIL catalogue/search.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 222, now: 274) FAIL valid "my" variable $page masks earlier declaration in same scope OK koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt -- You are receiving this mail because: You are watching all bug changes.