https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 --- Comment #13 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- (In reply to Joonas Kylmälä from comment #12)
Could we instead handle this like DaysMode, where the default is drawn from the pref, but you can add different values in the rules?
IMHO, it is dangerous to define same setting in two separate places because you only would know this by reading manual or help text next to these two settings and I don't think users usually read manuals.
Also defining the same rule in syspref and circ rule would make the code more complicated, please see the line
$charge = $rule_value ne '' ? $rule_value : C4::Context->preference("ExpireReservesMaxPickUpDelayCharge");
in the patch. And what if next time someone tries to fetch the charge that need to be made then they might miss out that oh, we had a syspref also. So at least we need to have helper method if a syspref is being used but I still think it leaves out the possibility of somebody just fetching the circulation rule because I at least would expect it to be the source of truth for charge value. -- You are receiving this mail because: You are watching all bug changes.