https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #72 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Tomás Cohen Arazi from comment #68)
The docs and you say the same: decode_json expects to be passed a string with Perl's internal format representing UTF-8 characters. And that's what encode_utf8 does, and why the patch introduces it at that exact place.
Perl internal format is certainly not UTF-8. Perhaps you are saying that here, but you could well mean something else too.. Not sure what you mean. But it is clear to me that we should not use decode_json here.
You can't fail what is correct :-P That is true. But this is absolutely not correct ;)
The cool thing is that you can propose some other solution. But I'd vote against something that adds more steps to the caller. If the right thing would take one more step, you should just take it.
-- You are receiving this mail because: You are watching all bug changes.