http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #110 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. Tompsett from comment #95)
The difficulty of a multi-patch bug fix is changing just parts after a code review. Only the ones with [NEEDS SIGN OFF] are changed compared to earlier versions which Chris Cormack signed off.
It is why it is preferable not to modify signed off patches. It is really hard for QAers to know what changes you introduced. Next time, prefer a followup, QAer can squash patches. I squashed 2 patches Bug 7567 - Undefined $lang triggers warning [NEED SIGN OFF] Bug 7567 - Remove excess line into Bug 7567 - Remove excess line And I provided 2 followups: 1/ Fix the sql query on getting rows from DB 2/ remove an unnecessary variable. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.