https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39419 --- Comment #24 from Brendan Lawlor <blawlor@clamsnet.org> --- Thanks for your patience and testing David and Andrew! Thanks for noting yarn api:bundle needs to be run for testing. For the tests failing, I think sometimes that can be caused by weird data from tests that failed to run completely, and I think you may need to do a reset_all. I'm still learning how to write a test like this, so it's also possibly something I did wrong This issue is a little confusing to unravel, but your comments were very helpful. I realize now that in addition to changes to the API, there needs to be some changes to the requests that create and modify the holds. Currently the patron_expiration_date can be set 3 different ways: When placing a hold: a) in the staff interface with setting a 'Hold expires on date' b) in the opac with setting a 'Hold not needed after' Or from the bib record's holds tab: c) by editing the date in the Expiration column The current behavior is that this sets both expirationdate and patron_expiration_date a) can be fixed in placerequest.pl b) can be fixed in opac-reserve.pl I'm not sure if this is the 'proper' way to do it, but since both fields should be set the same as expirationdate, it could be done by adding patron_expiration_date => $expirationdate, to the calls to AddReserve() c) is a little different because it is part of the datatable and ajax calls. I have to look into how to resolve that one. Thanks again! -- You are receiving this mail because: You are watching all bug changes.