https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42386 --- Comment #41 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 201612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201612&action=edit Bug 42386: Wire CanBookBeReserved to use Koha::Biblio::Availability::Hold CanBookBeReserved is now a thin wrapper around Koha::Biblio::Availability::Hold->check. Behavior changes: - Returns 'no_items' instead of '' when biblio has no items - Returns 'no_item_available' instead of last item's blocker when all items are blocked - Returns 'too_many_reserves' instead of '' when itemtype limit reached These are more descriptive statuses. All callers check eq 'OK' so non-OK values are equivalent. Assisted-by: Sonnet 4.6 (Anthropic) Test plan: 1. Apply patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Reserves.t \ t/db_dependent/Holds.t \ t/db_dependent/Koha/Biblio/Availability/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.