https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 74672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74672 Bug 2696: Fine payments should show what was paid for Review of attachment 74672: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=2696&attachment=74672) ----------------------------------------------------------------- ::: Koha/Account/Offset.pm @@ +20,4 @@
use Carp;
use Koha::Database; +use Koha::Account::Line;
Should be Koha::Account::Lines @@ +39,5 @@
+=head3 debit + +=cut + +sub debit {
POD missing. @@ +42,5 @@
+ +sub debit { + my ( $self ) = @_; + my $debit_rs = $self->_result->debit; + return unless $debit_rs;
I do not think we should "return unless" here, we do not do that for other methods. Is there a good reason? @@ +50,5 @@
+=head3 credit + +=cut + +sub credit {
Same as above ::: members/accountline-details.pl @@ +34,5 @@
+ query => $input, + type => "intranet", + authnotrequired => 0, + flagsrequired => { + borrowers => 1,
should be edit_borrowers. @@ +48,5 @@
+if ($accountline) { + my $type = $accountline->amount < 0 ? 'credit' : 'debit'; + my $column = $type eq 'credit' ? 'credit_id' : 'debit_id'; + + my @account_offsets = Koha::Account::Offsets->search( { $column => $accountlines_id } );
Would be better to call in scalar context and make the order by created_on here, not template-side. -- You are receiving this mail because: You are watching all bug changes.