https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 --- Comment #87 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to David Cook from comment #72)
I think something I find challenging about this patch set is that it makes a number of changes beyond including support for the timezone offset.
I think it might be easier to get this through if it were broken up into different bugzilla issues. For instance:
1. Correct tests for offset handling in RFC3339 dates 2. Don't fallback when date_format is passed 3. Correct offset handling in dt_from_string 4. Always return 'instance' local time
Honestly, the number of different changes just makes me less confident that I'm thoroughly testing everything and that makes me uncomfortable QAing this one.
Whilst I agree.. I think that's how I started but found that half the tests failed if I didn't follow through in one step. So much time has passed since I first wrote these patches that I must admit I'm struggling to unpick them myself :(. I'm going to take a look at refactoring the tests to get my head around what each test is actually testing. -- You are receiving this mail because: You are watching all bug changes.