https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21453 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 80140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80140 Bug 21453: blinddetail-biblio-search.pl/.tt use hardcoded subfield values for MARC21 Review of attachment 80140: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21453&attachment=80140) ----------------------------------------------------------------- ::: authorities/blinddetail-biblio-search.pl @@ +92,4 @@
# Get all values for each distinct subfield and add to subfield loop my %done_subfields; for ( $field->subfields ) { + next if $_->[0] eq '3'; # $3 will be set with authid value (in UNIMARC authorities)
UNIMARC isn't checked. Bad expression? @@ +129,3 @@
$template->param( + source => $source, + marcflavour => $marcflavour,
There is no need to pass a systempreference. ::: koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt @@ +35,5 @@
[%- FOREACH marc_value IN SUBFIELD_LOO.marc_values -%] [%- marc_value |replace("'", "\'") |replace('"', '\"') |replace('\n', '\\n') |replace('\r', '\\r') | html -%] [%- END -%] + [%- END -%][% IF ( marcflavour == 'UNIMARC' ) %]‡3[% authid %]"; + [% ELSIF ( marcflavour == 'MARC21' ) || ( marcflavour == 'NORMARC' ) %]‡9[% authid %]";
The filter is removed. QA Fail. @@ +137,4 @@
[% IF ( clear ) %] if (subfield){subfield.value="" ;} [% ELSE %] + [% IF ( marcflavour == 'UNIMARC' ) %]
Perhaps something like [% marcflavour = Koha.Preference('marcflavour') %] near the top? To avoid passing this as a parameter? -- You are receiving this mail because: You are watching all bug changes.