http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6840 --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #7)
This patch is fine, in my opinion. The comment made by Fred P 2011-12-13 16:52:38 UTC is a different problem, in my reading. I proposed a solution to his bug in bug 7630 (see also bug 7352).
The problem is not all modules call with the 'error' parameter set. And Fred P's suggestion of: #addition to test error parameter status if ( $error ) { $template -> param ( $error => 1, error => 1, ); } is overkill compared to simply splitting up the large $template->param() call, and having $template->param($error => 1) if $error; separately from the long list.
No, I didn't do any testing. I just don't want a good patch wasted. :)
Well setting $error=>1 is different because the value of $error isn't 'error' so you would have to change the template as well. To match that in your patch you arent setting error in the template -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.