https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34767 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155567|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 155636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155636&action=edit Bug 34767: Pass fee_ack into ::Transaction::Renew(All) This patch copies the $fee_ack field into the generated ::Transaction::Renew|All objects such that the fee acknowldegement flag is respected for renewals. Test plan To test: 1) Add a rental charge to an itemtype 2) Checkout an item of that itemtype to a user 3) Attempt a renewal of that item via SIP2 and note that it fails sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --patron 23529000035676 --item 39999000007756 -m renew 4) Pass the fee_acknowledgement bit in renewal and note the renewal still fails. sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --fee-acknowledged Y --patron 23529000035676 --item 39999000007756 -m renew 5) Apply patch and note the above now succeeds sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --fee-acknowledged Y --patron 23529000035676 --item 39999000007756 -m renew Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.