http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8253 wajasu <matted-34813@mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12653|0 |1 is obsolete| | --- Comment #23 from wajasu <matted-34813@mypacks.net> --- Created attachment 12666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12666&action=edit SIGNED-OFF-Bug-8253-Fine-doubling.patch Start early in the day, when you are feeling hopeful. Test: --------------To demonstrate bug: a) created a new VM with 3.8.5 dependencies loaded with koha-common b) created kohaclone c) git checkout -b bug8253_36x origin/3.6.x d) perl Makefile.pl with dev install ( mysqladmin -uroot -p create koha, with user/pass = koha, grants/flush ) e) make; make install f) adjust install for web/staff access g) stepped through web installer to initialize fresh database (installer updatedatabase.pl happens) h) created a "student" patron stud1 i) cataloged a couple of books with z3950 search ( barcode 111 and 222 resprectively) j) configured circulation rules to charge $1.50 for each day overdue (Home ? Administration ? Circulation and Fine Rules ) ( All, All, 10, 10, blank, 1.50,1,0,0,0,0 click add ) k) configured overdue notice/status triggers (1st 1 day, 2nd 2 days) for "student" "Overdue Notice" ( Home ? Tools ? Notice Triggers) l) configured finesmode in syspref with "calculate & charge" m) checked out one book with duedate 1 day in past for patron stud1 barcode 111 n) checked out other book with duedate 2 day in past for patron stud1 barcode 222 o) used mysql to "select * from accountlines;" to see what fines exist (no dupes just rental charges, 2 $5.00 entries ) p) run misc/cronjobs/fines.pl q) used mysql to "select * from accountlines;" to see what fines exist (no dupes just two additional entries for our two overdue books) r) brought in new kohaclone s) git checkout -b bug8253_38x origin/3.8.x t) performed steps d (except no new db to create though) thru step g (new version of updatedatabase.pl) u) used mysql to "select * from accountlines;" to see what fines exist (no dupes) v) run misc/cronjobs/fines.pl w) used mysql to "select * from accountlines;" to see what fines exist (DUPES) - bug 8253 --------------To test bug fix: y) do the same as above (with a fresh new mysql DB) but after step s) apply the patch: git am -i -u -3 <thepatch> and proceed with steps t [BE SURE TO APPLY d-g] and then continue with steps u thru v z) used mysql to "select * from accountlines;" to see what fines exist (no dupes) - TEST PASSES Signoff patch generation: git commit --amend git format-patch -s origin/3.8.x Note: You can't reuse the database because it won't be upgraded. :) Note: Patch assumes F/FU accountlines will not already have ' 23:59' on the end, but this patch only addresses the folks who upgrade, not the ones who already upgraded. There is another bug fix script for that. Note: QA - A variation on this test, if you can, is to create a fine that has accounttype='F', since I only had 'FU' wajasu -- You are receiving this mail because: You are watching all bug changes.