https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40275 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #20 from David Cook <dcook@prosentient.com.au> --- Ohhh I just saw that Kyle added the patch for Koha::Patrons->find_by_identifier to check_cookie_auth in response to Aleisha's comment. Yeah, rather than doing that let's do something more like this: my $patron = Koha::Patrons->find({ borrowernumber => $session->param('number') }); That's going to be way better. -- I'm just going to quickly pop this to "In Discussion". Do we want to drop the patch "Implement find_by_identifier for check_cookie_auth" and handle the move to borrowernumber on a separate bug? Alternatively, we leave the patch in, but knowing that it really should be replaced with a borrowernumber lookup? I think Aleisha raises a really interesting point here. -- You are receiving this mail because: You are watching all bug changes.