https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42432 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I've failed QA as the new tests don't pass (things work as per the first patch, once I got my head around it). This occurs for me when running the tests with both patches, or with just the test patch. Test failures: 0 passing (50s) 2 failing 1) Circulation - AllowRenewalOnHoldOverride 'On hold due date' sends the 'On hold due date' value to svc/renew for on-hold items: AssertionError: Timed out retrying after 20000ms: expected '<table#issues-table>' to be 'visible' This element `<table#issues-table>` is not visible because it has CSS property: `display: none` at Context.eval (webpack://koha/./t/cypress/integration/Circulation/OnHoldDueDate_spec.ts:38:52) 2) Circulation - AllowRenewalOnHoldOverride 'On hold due date' falls back to 'Renewal due date' for non-on-hold items: AssertionError: Timed out retrying after 20000ms: expected '<table#issues-table>' to be 'visible' This element `<table#issues-table>` is not visible because it has CSS property: `display: none` at Context.eval (webpack://koha/./t/cypress/integration/Circulation/OnHoldDueDate_spec.ts:75:60) (Results) ┌────────────────────────────────────────┐ │ Tests: 2 │ │ Passing: 0 │ │ Failing: 2 │ │ Pending: 0 │ │ Skipped: 0 │ │ Screenshots: 2 │ │ Video: true │ │ Duration: 50 seconds │ │ Spec Ran: OnHoldDueDate_spec.ts │ └────────────────────────────────────────┘ ..... Spec Tests Passing Failing Pending Skipped ┌──────────────────────────────────────────────────────────────────────────────────┐ │ ✖ OnHoldDueDate_spec.ts 00:50 2 - 2 - - │ └──────────────────────────────────────────────────────────────────────────────────┘ ✖ 1 of 1 failed (100%) 00:50 2 - 2 - - -- You are receiving this mail because: You are watching all bug changes.