https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39637 --- Comment #21 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #19)
Hi, I just noticed this attempt to make a big change on the API architecture. Lucas brought it to me. Adding Jonathan and Martin to the conversation as well.
This is not that big :) Just a few additional parameters to repair what was broken when we switched from svc/members/search to the REST API.
I saw several reports about the same and I agree with the basics of this implementation: i.e. a query parameter for telling what to search, and another one for where.
Is this actually needed elsewhere ?
What we lack here is:
* The query builder should be a helper in `Koha::REST::Plugin::Query` * Retrieving the parameters and building a query (with the helper) should be backed into `objects.search`. * The JS part should be done in datatables.js so we fix all tables the same way. The patrons one has a lot of fields to query on because of the extended attributes, but so the ILL one, etc. * I would add an option parameter to KohaTable, something like `compact_search: true` to choose which kind of search to build. This way we can migrate the tables one by one, taking care of their specifics.
I'm willing to help here.
This looks like trying to generalize too much too soon. Is there another API endpoint that can benefit from this right now ? -- You are receiving this mail because: You are watching all bug changes.