https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42161 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks everyone for testing, and Lisette's Failed QA was fair: the issue does not reproduce with the steps in comment 0. I have gone back through it properly and the original patch overstated things: - The claimed fatal error (keys %{undef}) for a patron with no existing attributes is wrong. The hashes autovivify, so that case already works on main. I have dropped that change and its test. - The second claim, that the value comparison does not filter by attribute code, is a real bug. The steps in comment 0 do not trigger it, because only one non-mandatory attribute is left blank there. It is triggered when the stored value of an attribute equals the submitted value of a different attribute. The typical case is a patron who self-registered leaving two non-mandatory attributes blank: both are stored with an empty value, and setting one of them in the OPAC later is ignored because the other is still submitted as empty. If nothing else changed, no modification request is created at all. I reproduced this on current main at the Koha::Patron level in KTD: stored ONE='' and TWO='', submitted ONE='' and TWO='wheelchair' returns no changes on main, and returns the change to TWO with the patch. I have not clicked through the OPAC and staff interface, so please shout if the new test plan does not behave as described. New patch attached (rebased on current main): - the commit message now describes only the real bug - the two new tests both fail without the fix and pass with it, and they check which attribute is returned, not just the count - the test plan uses two blank attributes The earlier signed-off patch is obsoleted as the code and tests changed, so this needs a fresh sign-off. Sorry for the noise. -- You are receiving this mail because: You are watching all bug changes.