http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I took a look at the code (at all 3 patches together) and noticed some small things: 1) Plase use the new isSuperlibrarian instead: unless ($userflags->{superlibrarian} 2) Please update the database update comment: + print "Upgrade to $DBversion done (Add aqorders.branch and permission order_receive_all)\n"; 3) Capitalization I know it's an old line, but could you please fix? + Duplicate Barcode 4) The new test file (thx!) doesn't output any comments. It would be nice to see some more documentation there. -- You are receiving this mail because: You are watching all bug changes.