https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34353 --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 198230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198230&action=edit Bug 34353: (QA follow-up) Atomicupdate cleanup - Set the executable bit on the atomicupdate so it passes the QA file_permissions check. - Drop the unused 'say_info' import; only 'say_warning' and 'say_success' are now needed. - Capture the row count from the DELETE so we report 'say_warning' on a re-run (when the syspref is already gone) instead of falsely claiming to have deleted it again. - Add an inline comment explaining the conservative '(is_hidden OR VALUES(is_hidden))' conflict-resolution rule used when a table-settings row already exists alongside the old syspref value. Test plan: 1. Verify the atomicupdate file has the executable bit set. 2. On a database where the syspref is still present, run the atomicupdate. Confirm output reads "Deleted 'SpineLabelShowPrintOnBibDetails' syspref". 3. Run the atomicupdate a second time. Confirm output now reads "'SpineLabelShowPrintOnBibDetails' syspref already removed". 4. Confirm the columns_settings rows are unchanged on re-run. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.