http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 43831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43831 Bug 14310 - Suspend and resume indvidual holds from patron holds table Review of attachment 43831: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14310&attachment=43831) ----------------------------------------------------------------- Hi Kyle, I have patches from the 2 dependent bugs and this one. QA script is clean, but code review and testing showed 2 big problems: 1) Suspending holds doesn't work for me, clicking on Suspend with or without a date - nothing happens. Tested from /cgi-bin/koha/members/moremember.pl?borrowernumber=1 Firebug: Post: reserve_id=407&suspend_until=31%2F10%2F2015 Response: <!-- TEMPLATE FILE: 500.tt --> error page. 2) Almost all the new strings are not translatable, because they are trapped inside the .js file. ::: koha-tmpl/intranet-tmpl/prog/en/js/holds.js @@ +129,5 @@
+ if ( oObj.found ) { + return ""; + } else if ( oObj.suspend == 1 ) { + return "<a class='hold-resume btn btn-link' id='resume" + oObj.reserve_id + "' style='display: inline; white-space: nowrap;'>" + + "<i class='icon-play'></i> " + _("Resume") + "</a>";
.js files are not translatable - we need to move the strings to the templates or find another solution to this. @@ +132,5 @@
+ return "<a class='hold-resume btn btn-link' id='resume" + oObj.reserve_id + "' style='display: inline; white-space: nowrap;'>" + + "<i class='icon-play'></i> " + _("Resume") + "</a>"; + } else { + return "<a class='hold-suspend btn btn-link' id='suspend" + oObj.reserve_id + "' style='display: inline; white-space: nowrap;'>" + + "<i class='icon-pause'></i> " + _("Suspend") + "</a>";
Same as above, and many more below. -- You are receiving this mail because: You are watching all bug changes.