https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101239|0 |1 is obsolete| | Attachment #101240|0 |1 is obsolete| | Attachment #101241|0 |1 is obsolete| | Attachment #101242|0 |1 is obsolete| | Attachment #101243|0 |1 is obsolete| | Attachment #101244|0 |1 is obsolete| | Attachment #101245|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101285&action=edit Bug 24759: Move OpacRenewalBranch code to Koha::Item This patchset moves all code to calculate the correct renewal branch into Koha::Item.pm When interface is opac we follow the syspref, otherwise we use the current userenv, or pass through a defined branch To test: 1 - Check out an item to a patron 2 - Set allowed renewals in the circ rules to 100 (just so you can keep testing) 3 - Renew the item in staff interface, confirm it is recorded correctly in statistics table (as signed in branch) 4 - Renew via the opac, testing with each setting of OpacRenewalbranch 5 - prove -v t/db_dependent/Koha/Item.t Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.