http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9005 --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #6)
(In reply to comment #5)
(In reply to comment #4)
This patch can solve a bugguy behaviour at the price of loosing a very interesting cache feature.
No, it doesn't. It solves a major bug with no side-effects for systems that aren't affected by the bug. It is 100% opt-in. I feel that libraries that are changing sysprefs *sometimes* will complain. And we must find a generic way to solve the "rare change of datas", or we won't be able to add more caching. For example, we could store in a global/"static" variable the issuingrules, to avoid reading them on each checkin. But if they are changed, how the librarian administrator will be able to propagate it on Plack ?
Sure, a generic solution is great. The solution is to use proper caching, not the mess we have in C4::Context. I favor fastmmap. However, I am not fixing now. What I am doing is trying to make my six months less frustrating than they would be if I had to restart Plack manually every couple of seconds. Global/static variables have no place in a persistent environment, in my opinion.
investigating the documentation, I find : https://github.com/miyagawa/Starman that says :
Starman is a PSGI perl web server that has unique features such as: Signals Supports "HUP" for graceful worker restarts, and "TTIN"/"TTOU" to dynamically increase or decrease the number of worker processes, as well as "QUIT" to gracefully shutdown the worker processes.
wouldn't a page/link in the admin section that "reload" the server at user request be useful ?
It might be. However, that would mean designing Koha to send SIGHUP to a web server which might or might not require setuid. Yikes! I can see if the Shotgun loader offers a workaround. However, I think the *option* to disable the cache is still needed. The patch makes no change to the current behavior for those Plack users who don't want to add "C4::Context->disable_syspref_cache();" to their psgi file. -- You are receiving this mail because: You are watching all bug changes.