https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #6)
Some things:
1) Tiny typo in "subflied":
$(this).parent().find('.hint').html(_("Enter a regular expression for this subflied"));
2) I am not happy witht he GUI. The delete checkbox always takes some time explaining and I think having now 2 unlabelled checkboxes makes it worse. Maybe a link or small button "RegEx" would work? Adding Owen to see if he has an idea.
Definitely, we should not have a second checkbox
3) During our discussion on bug 15836 we came to the conclusion that a separate permission should be added for that page as there are some potential issues with the regex. In our libraries a lot of people have item batch edit permissions, as this is a super useful tool. In wonder if we need to take extra precautions here. Adding some people in hope for a second opinion.
Nope, not in this case, see how MMT works. However we should list the available modifiers, see Koha/SimpleMARC.pm:627 my @available_modifiers = qw( i g ); 4) ident must be 4 spaces 5) why do you use eval for the regex? Same as before, I feel like you should mimick Koha::SimpleMARC::_modify_values -- You are receiving this mail because: You are watching all bug changes.