https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37984 Bug ID: 37984 Summary: Binary attachment cannot be sent via C4::Letters::EnqueueLetter() Change sponsored?: --- Product: Koha Version: 21.11 Hardware: Macintosh OS: Mac OS Status: NEW Severity: new feature Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: svoboda@rbit.cz QA Contact: testopia@bugs.koha-community.org CC: black23@gmail.com I use koha testing docker in Mac OS. This code does not send a valid e-mail binary attachment: $pdf_binary_content = ...; my @attachments = ( { filename => 'attachment.pdf', type => 'application/pdf', content => $pdf_binary_content, } ); my $message_id = C4::Letters::EnqueueLetter({ ... ... ... attachments => \@attachments, }); because in C4::Letters is in _add_attachments function attachment encoding: ... Encode::encode( "UTF-8", $attachment->{content} ) ... I can't encode a binary file... Possible solution (C4::Letters): sub _add_attachments { ... foreach my $attachment ( @$attachments ) { $message->attach( # ################################################################## # Original code: Encode::encode( "UTF-8", $attachment->{content} ), # New code: defined $attachment->{binary} ? $attachment->{content} : Encode::encode( "UTF-8", $attachment->{content} ), # ################################################################## content_type => $attachment->{type} || 'application/octet-stream', name => $attachment->{filename}, disposition => 'attachment', ); } ... } my @attachments = ( { ... binary => 1, } ); my $message_id = C4::Letters::EnqueueLetter({ ... ... ... attachments => \@attachments, }); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.