http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #158 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to M. Tompsett from comment #156)
I have some other related questions: - should validate URLs, since not all 856$u urls will be uploaded file urls. Not sure I understand well the question, but isn't misc/cronjobs/check-url-quick.pl what you're asking ?
- external urls will generate the same apparent error deleting as the cloning scenario I mentioned in comment #154. see my previous answer.
- is telling a user to check errors logs reasonable? They may not have shell access to the system. No, it isn't
- If a valid external url is detected, then a different response is needed than if we discover a url to a deleted file. I think check-url-quick.pl achieve the goal, and it's better because it detects when an URL becomes invalid at any time.
- How will the user know to delete the text field before clicking the plugin icon in order to continue onto the upload screen to put a different file in place? I don't understand this one.
The signed off patches need a rebase. Feedback on these questions would be useful. I'm leaving the status at In Discussion, because even if my patch was signed off, the problem with respect to external urls and deleted files, due to a clone, would still exist. And that seems like enough to merit not just running for QA's approval. Are my answer OK and is it back to go to signed-off ? (I have not tested the patches still applies cleanly)
-- You are receiving this mail because: You are watching all bug changes.