http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4162 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30899|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30922&action=edit [PASSED QA] Bug 4162 - Followup: only count potential barcodes The $lines_read++; was before the code which skipped empty lines. By moving it after the next unless $barcode; code, the $lines_read variable only counts potential barcodes, and does not include empty lines. TEST PLAN --------- 1) Apply patch. 2) Attempt a valid barcode file with empty lines. -- The potential barcode count should exclude the empty lines. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Empty lines are now no longer counted as potential barcodes. Passes tests and QA script. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.