https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40062 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m --- Comment #4 from Lisette Scheer <lisette@bywatersolutions.com> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #3)
I just tried it with my patch and the results are similar. The big question here is: what is the expected behavior? If I add 4 holds on the same item, with priority=1. For me, if 1 is the highest, then it means the result should be:
* p=1 -> hold_4 * p=2 -> hold_3 * p=3 -> hold_2 * p=4 -> hold_1
i.e. the hold is inserted with the requested priority, and the existing ones are shifted if required.
This makes sense to me
And if we had:
* p=1 -> hold_1 * p=2 -> hold_2 * p=3 -> hold_3
and we added `hold_4` with priority=2, I would expect the result to be:
* p=1 -> hold_1 * p=2 -> hold_4 * p=3 -> hold_2 * p=4 -> hold_3
Does it make sense? I got it wrong?
This also makes sense to me. I would also expect holds without a defined priority to go at the end of the list. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.