http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 39317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39317 [SIGNED-OFF] Bug 14198: RDA: Indexing 264 field (Zebra) Review of attachment 39317: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14198&attachment=39317) ----------------------------------------------------------------- Hi Hector, thx for providing this patch! I think it's about time we get ready for RDA a bit more, indexing being a part of it. I have added some comments - can you please take a look? For next time: I think it would be a bit nicer if you had split out the XSLT changes into a separate bug - keeping indexing and display separate issues, but I can see how this works together here. ::: etc/zebradb/biblios/etc/bib1.att @@ +220,4 @@
att 9010 cn-suffix att 9011 Suppress att 9012 Identifier-other +#att 9013 arp
What is arp? It seems unrelated to the patch set, but is added by it. ::: etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml @@ +431,4 @@
<index_data_field tag="260"> <target_index>pl:w</target_index> </index_data_field> + <!--Index for Provider 260-->
There are already entries for 260 and its subfields - why keep this separate and not add the new <target_index> entries within the existing ones? ::: etc/zebradb/marc_defs/marc21/biblios/record.abs @@ +129,4 @@
melm 260$b Publisher:w,Publisher:p melm 260$c copydate,copydate:s melm 260 pl +melm 260$a Provider-place:w,Provider-place:p
The changes to record.abs are not necessary and should be removed, as GRS1 is deprecated. I'd leave them in, but I think they are also not correct. There should only be one entry for each MARC field in record.abs - the new indexes should be listed additionally with the old entries. Easier to remove the file from the patch set. ::: koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl @@ +273,5 @@
<xsl:value-of select="$field/marc:subfield[@code='a']"/> <xsl:text> </xsl:text> + <xsl:choose> + <xsl:when test="$url='1'"> + <a href="/cgi-bin/koha/catalogue/search.pl?q=pb:{$field/marc:subfield[@code='b']}">
I believe the link here is for the intranet, while it should be an OPAC link. -- You are receiving this mail because: You are watching all bug changes.