https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38050 --- Comment #51 from David Cook <dcook@prosentient.com.au> --- (In reply to Jacob O'Mara from comment #50)
There is no handling for if the virtualshelves pref is disabled, though this is currently consistent with other api’s. I couldn’t find any instances where we DO handle that. For instance the ERM api’s seem to all still work while it’s disabled and I couldn’t find any logic that should stop them from doing so. While I could technically add a syspref check at the top of all of the api methods, I think we would be better suited handling this at the router/swagger level. I can add a bug to that effect if you agree? Or, if I’m wrong, if you could point me at an example of endpoints that handle this, I would be happy to follow up.
That's really interesting. I was working on an API endpoint recently and ran into that exact issue. It would be good to have a systematic approach to this. I think that if the feature is disabled then the API endpoints should be disabled too. -- You are receiving this mail because: You are watching all bug changes.