https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30326 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Hi, a couple remarks: 1. I'm not sure about the output, meaning that maybe as other scripts do, it could have an option switch for different formats. Not a blocker 2. In the --bibnum use case, it is not handling non-existing records correctly. It should report it correctly (right now it tells 'Must pass a MARC::Record object to check_record' which might be misleading for the end user). 3. I suggest you add a --where parameter, that is passed as a literal query to Koha::Biblios->search( $query, { prefetch => ['biblio_metadata'] } ); and use $biblio->metadata->record instead of GetMarcBiblio. Failing because of 2, primarily. -- You are receiving this mail because: You are watching all bug changes.