https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am sorry Kyle but I really don't think we should push the tests as they are written. We should expect one loop and a sum following some conditions, like I tried in my patch. That will highlight inconsistencies (like the one I raised in the previous comments). Also the amounts are always 10, so we cannot know which ones is really picked (reading the tests I mean). We should improve our test suite, and those tests are not in the right direction in my opinion. Asking for another QA point of view. -- You are receiving this mail because: You are watching all bug changes.