https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16041 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jacek Ablewicz from comment #12)
(In reply to Marcel de Rooy from comment #11)
(In reply to Jonathan Druart from comment #3)
This feature is enabled by default, but the users are not aware of it and it costs a lot of time processing to get the images. What is a lot? I see e.g. 0.06sec
Total cost: (get_biblio_authorised_values() call cost) * (number of search results)
get_biblio_authorised_values() cost: GetMarcStructure() + ca 8 msec
GetMarcStructure() cost:
master w/ memcached: 62 msec
master w/o memcached: 40 msec (depending on the mysql config - Cache::Memory is currently nonfunctional, framework structures are fetched from DB directly - see Bug 16104 comment #8)
master w/ memcached + Bug 16221: 18 msec
master w/ memcached + Bug 16166: 10 msec
master w/ memcached + 2nd patch from Bug 16140: 0.3 msec
For eg. 50 search results per page, it currently adds up to 3.5 seconds (master w/ memcached) or ~2 seconds (master w/o memcached) - on the relatively fast server.
First, please note that I fully support this report. I was about to pass QA on it when Katrin already did. But I could not resist to bring the performance gain into some perspective. It is only very good to prevent useless calls to get_authorised_value_images and get_biblio_authorised_values. There should definitely be a cheaper way to get some imageurls than going thru GetMarcStructure etc. These two routines are quite horrible actually. But forgive me noting that I do not agree with multiplying this gain with factor 50 :) This patch only deals with opac-detail.pl.. -- You are receiving this mail because: You are watching all bug changes.