https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 --- Comment #104 from Nick Clemens <nick@bywatersolutions.com> --- I am still unsure about one of the lines here: In CanBookBeReserved, during the item loop: return { status => 'recordHoldNotAllowed' } if $opacitemholds eq 'F'; If one of the items is type 'new' and doesn't allow record level holds, but another is 'book' and does allow it - we will return 'recordHoldNotAllowed' if we hit the 'new' item first. You also call 'get_opacitemholds_policy' in CanBookBeReserved and also add a call to get_effective_rules in CanItemBeReserved - these should be getting the same rule - why do we need to check at both levels? The check in CanItemBeReseerved should handle returning the necessary status -- You are receiving this mail because: You are watching all bug changes.