https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34596 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Nick Clemens (kidclamp) from comment #10)
(In reply to Martin Renvoize (ashimema) from comment #9)
Fancy having a go that those unit tests Nick?
I haven't written the tests because I wonder if we should go about this in a different way.
The current patches have AddReturn check the context of the call essentially and ignore the specific problematic case.
I think it might be better to remove the queue rebuild from AddReturn and call it explicitly where needed from the scripts that call AddReturn.
It will be more code, but should be more obvious. Thoughts?
We'd love to see this move forward. Martin, do you have thoughts on Nick's questions? -- You are receiving this mail because: You are watching all bug changes.