https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35369 --- Comment #10 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Victor Grousset/tuxayo from comment #8)
It seems the default value has a space at the end for formatting reasons when there are multiple messages. Which becomes unreliable now that the message is configurable.
So without a space in the syspref and with an account expired I get: «Greetings from Koha.Your account has expired»
But with a negative account balance it's «Greetings from Koha. -- Patron blocked by fines -- Patron owes 199.00»
And with a message for OPAC, its become: «Greetings from Koha. Messages for you: 09/25/2024: Stop putting the books in the wrong shelves!»
Without the patch there were two spaces. So it's a mess >_<
I now added a space if the greeting is defined
To avoid just swapping a formatting issue with another and move to a more consistent behavior, should we add " -- " to these lines?:
$kp->{opacnote} .= "Your account has expired as of $dateexpiry"; [...] $kp->{opacnote} .= "Your card will expire on $dateexpiry"; https://git.koha-community.org/Koha-community/Koha/src/branch/main/C4/SIP/ ILS/Patron.pm#L83
I can do a follow-up. I just need a 2nd look at the idea.
I think this is another bug :-) (In reply to Victor Grousset/tuxayo from comment #6)
It's not like SIP2ScreenMessageGreeting is supposed to contain TT syntax and might need to use patron info. (I tried to put [% 'test' %] to double check and it doesn't work)
It should, it worked for me, added to test plan (In reply to Victor Grousset/tuxayo from comment #7)
unused variable?
Removed one, the other is used from what I see -- You are receiving this mail because: You are watching all bug changes.