https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41449 Bug ID: 41449 Summary: Reserves.t may fail when on shelf holds are restricted Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org [1] Around line 1486, it is assumed that onshelfholds == 1. If you set the circ rule to If any unavailabe, the test fails. t/db_dependent/Reserves.t .. 60/71 # Failed test 'Item not available for item-level hold because no effective item type' # at t/db_dependent/Reserves.t line 1486. # Looks like you failed 1 test of 3. => Fix that assumption. Note btw that the lines following the error, onshelfholds is set to 0. [2] The test description is misleading and incorrect (copied from an earlier one, not adjusted) ok( C4::Reserves::IsAvailableForItemLevelRequest( $item, $patron ), "Item not available for item-level hold because no effective item type" ); => The item is available because '0' is defined. -- You are receiving this mail because: You are watching all bug changes.