https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36672 Bug ID: 36672 Summary: Circulation rules are performing too many lookups Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com See bug 36668 - it tackles the size of the circulation page but doesn't significantly increase load time. Profiling it seems we spend about 50% of the loading time on Koha::Template::Plugin::CirculationRules::Search Looking at the template, for every section after the main rules block we loop over categories or itemtypes, and lookup the value for each rule name. In systems with large numbers of categories and item types this becomes very slow. In the rules section, we have already built a hash of rules by category and itemtype - we should continue to use this throughout the page. Additionally, we don't need to use all category/item types, we can use the 'used_categories' array from bug 36447 to only attempt categories that we know have rules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.