https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43553 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Back to Signed Off for QA. The failure was that the double-dash spelling would break existing cron lines such as "holds_reminder.pl -days 3 -lettercode HOLD_REMINDER", which is how the script's old usage text told people to write them. That is solved in the framework, by the new patch on bug 43557 (attachment 208591), which this bug now depends on: Koha::Script->describe_options accepts the legacy single-dash long options, rewrites them to the standard double-dash form and prints a deprecation warning to STDERR (cron mails it to the administrator). So existing setups keep working while they migrate, --days remains the documented form, and the shim is meant to be removed in a future release. The patch on this bug is unchanged (attachment 208599); it is only rebased on top of bug 43557. Checked with both applied: - holds_reminder.pl -days 3 -lettercode HOLD_REMINDER -v runs normally and prints one "WARNING: -days is deprecated, use --days instead" line per legacy option - holds_reminder.pl --days 3 --lettercode HOLD_REMINDER -v runs without any warning - holds_reminder.pl -help prints the usage Test plan: 1. Apply bug 43557 and this patch 2. perl misc/cronjobs/holds/holds_reminder.pl -days 3 -lettercode HOLD_REMINDER -v => it runs, with the deprecation warnings 3. perl misc/cronjobs/holds/holds_reminder.pl --days 3 --lettercode HOLD_REMINDER -v => it runs, without warnings Andrew, if you agree, a line in the release notes about the deprecation (single-dash long options will stop working in a future release) would be worth having, on bug 43557. -- You are receiving this mail because: You are watching all bug changes.