[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Just minor (not blocker), reading the code: 1. In Koha::Account::Line->apply + my $offset_type = $params->{offset_type} // 'credit_applied'; Should not we raise an exception if the offset_type is not known? I would also list the possible values in the POD (or at list tell it comes from account_offset_types) 2. I think we should follow the pattern "Credit Applied", instead of switching to snake_case "credit_applied" only for this new one. 3. is_debit, is_credit - what about amount == 0? -- You are receiving this mail because: You are watching all bug changes.