[Koha-bugs] [Bug 9394] Use reserve_id where possible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 --- Comment #38 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to comment #37)

Good catch! I'm re-evaluating it right now and I don't think it's going to affect anything. Koha does not expose canceled reserves iirc, so a scenario where a canceled reserve has it's priority altered shouldn't come up. That may be why Jonathan added the check.

Indeed; I understand the purpose of the check, I'm just trying to encourage folks to write unit tests for most any change to core routines, even obvious ones. -- You are receiving this mail because: You are watching all bug changes.