https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |nick@bywatersolutions.com --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Please make the statement idempotent (INSERT IGNORE) Add the pref to sysprefs.sql for new installs I think the conditional can be further simplified: - my $transport = 'email'; - if (C4::Context->preference("FallbackToSMSIfNoEmail")) { - $transport = ($patron->smsalertnumber) && (!$patron->email) ? 'sms' : 'email'; - } + my $transport = (C4::Context->preference("FallbackToSMSIfNoEmail")) && ($patron->smsalertnumber) && (!$patron->email) ? 'sms' : 'email'; -- You are receiving this mail because: You are watching all bug changes.