https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #86 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Great job, Francesco I did not finish my QA now, but want to report some issues I found already. And they unfortunately confirm that this patch set will not make it anymore into 18.05 ;) But it would be good to have in master early. qa tools: FAIL Koha/Patron.pm, FAIL pod, Spurious text after =cut deleted_at should probably be better: deleted_on; we also have updated_on etc. $dbh->do( "ALTER TABLE biblio ADD COLUMN deleted_at datetime DEFAULT NULL" ) or warn $DBI::errstr; Probably it warns already and you should die here ? Running OAI/Server.t ok 12 - use Koha::OAI::Server::ResumptionToken; DBD::mysql::db do failed: Table 'koha_dev.deletedbiblio' doesn't exist [for Statement "DELETE FROM deletedbiblio"] at t/db_dependent/OAI/Server.t line 68. DBD::mysql::db do failed: Table 'koha_dev.deletedbiblioitems' doesn't exist [for Statement "DELETE FROM deletedbiblioitems"] at t/db_dependent/OAI/Server.t line 69. DBD::mysql::db do failed: Table 'koha_dev.deleteditems' doesn't exist [for Statement "DELETE FROM deleteditems"] at t/db_dependent/OAI/Server.t line 70. git grep deletedbiblio about.pl: q|select b.biblionumber from biblio b join deletedbiblio db on b.biblionumber=db.biblionumber|, koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/web_services.pref (a few other refs too) git grep deleteditems about.pl again koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt: <td><input type="radio" name="Line" value="deleteditems.timestamp" /></td> might not be a problem? misc/export_records.pl: WHERE deleteditems.biblionumber = ? AND deleted_at IS NOT NULL does not look good reports/catalogue_stats.pl: $linefilter[0] = @$filters[15] if ( $line =~ /deleteditems\.timestamp/ ); we should probably get rid of those things; they are confusing now -- You are receiving this mail because: You are watching all bug changes.