https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 --- Comment #95 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #94)
=== Patch 1 C4/Labels/Label.pm L100 require Koha::Libraries; Remember you failed patches before for that? :)
Yes :) But I have replaced an existing require with another one, not added a new one.
L101 # FIXME Is this used?? Not sure. But can you use those fields when you define a label in the editor or something? One of the templates contains the string in text and implicitly seems to suggest that. t/db_dependent/Reserves.t still fails (cause somewhere else)
Yes, see bug 16942.
=== Patch 2 Auth.pm: use for Branches removed; but still called. (Will be resolved, yes) TODO in C4/Search.pm L337
Yes it's a TODO, for later.
koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt: Exceptional [% l.branchname || 'UNKNOWN' %] Inconsistent?
No, the UNKNOWN comes from the pl. Now it's translatable.
t/db_dependent/Holds/RevertWaitingStatus.t DBIx::Class::ResultSet::next(): [SQL::Abstract::__ANON__] Fatal: unexpected operator 'cancellationdate' with undef operand at /usr/share/koha/masterclone/Koha/Objects.pm line 168 Probably something similar as in Reserves.t
Same as before, see bug 16942. Thanks for QAing, really much appreciated! -- You are receiving this mail because: You are watching all bug changes.